Some UI tweaks for New App Layout #6535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- First implementation
# Conflicts: # Riot/Generated/UntranslatedStrings.swift
- Update after reviews
- Added new analytics
- Last tweaks
- fixed theme issues
- fixed build after merge - renamed AllChats classes
- new Build settings newAppLayoutEnaled
- Removed the Pinned space feature
- Removed the All chats layout editor screen - Added feature flag - Added context menus
- Removed analytics used for IA test
- Added Space selector bottom sheet - Changed placement for the context menus in the all chats screen
- Code tweaks
- Code cleanup
…Implement_new_Space_selector_bottom_sheet
- Update after design review
- Update after review
- Code cleanup
…Implement_new_Space_selector_bottom_sheet # Conflicts: # Riot/Modules/ContextMenu/ActionProviders/AllChatsActionProvider.swift # Riot/Modules/Home/AllChats/AllChatsViewController.swift
- Added space switching analytics - Implemented unit and UI test for space selector bottom sheet
- Animation for bottom action panel - UI tweaks
- Temporarily reintroduced invites
Co-authored-by: Doug <[email protected]>
- Update after code review
…vector-im/element-ios into gil/6079-Delight_Edit_layout_experiment
- Changed Recents type to Breadcrumbs
- Update after code review
- Update after code review
…Implement_new_Space_selector_bottom_sheet # Conflicts: # Riot/Modules/Home/AllChats/AllChatsActionPanelView.swift # Riot/Modules/Home/AllChats/AllChatsActionPanelView.xib # Riot/Modules/Home/AllChats/AllChatsViewController.swift # Riot/Modules/TabBar/TabBarCoordinator.swift
- Do not show coach message with the new App Layout
…tom_sheet # Conflicts: # Riot/Assets/en.lproj/Vector.strings # Riot/Generated/Strings.swift # Riot/Modules/Common/Recents/DataSources/RecentsDataSource.m # Riot/Modules/Common/Recents/Service/MatrixSDK/RecentsListService.swift # Riot/Modules/Common/Recents/Service/Mock/MockRecentsListService.swift # Riot/Modules/Common/Recents/Service/RecentsListServiceProtocol.swift # Riot/Modules/ContextMenu/ActionProviders/AllChatsActionProvider.swift # Riot/Modules/Home/AllChats/AllChatsViewController.swift # Riot/Modules/Home/AllChats/AllChatsViewController.xib # Riot/Modules/TabBar/TabBarCoordinator.swift
- Removed unnecessary images - Changed for SVG format
- Now using the default toolbar of the navigation controller
- Removed the swipe actions menu in recents
- Reverted some Theme tweaks to fix some UI regressions
- Added change log - Hide toolbar when leave All Chats screen
- update after code review
…o gil/6534-Some_UI_tweaks_for_New_App_Layout # Conflicts: # RiotSwiftUI/Modules/Spaces/SpaceSelectorBottomSheet/SpaceSelector/View/SpaceSelector.swift
- Added some comments
…o gil/6534-Some_UI_tweaks_for_New_App_Layout # Conflicts: # Riot/Modules/ContextMenu/ActionProviders/AllChatsEditActionProvider.swift
Base automatically changed from
gil/6410-Implement_new_Space_selector_bottom_sheet
to
develop
August 5, 2022 11:39
# Conflicts: # Riot/Modules/ContextMenu/ActionProviders/AllChatsEditActionProvider.swift # Riot/Modules/Home/AllChats/AllChatsViewController.swift # RiotSwiftUI/Modules/Spaces/SpaceSelectorBottomSheet/SpaceSelector/View/SpaceSelector.swift
|
Kudos, SonarCloud Quality Gate passed!
|
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/YM6fH5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #6534