Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove overlap of sender name and first message tap targets. #6332

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Jun 22, 2022

The XIBs had the tap target extending 6pt below the name. This resulted in a frequent occurrence where you would go to tap the top message but end up tapping the name instead. This PR sets the bottom constant to 0pth to align with the name label. In my testing it was no harder to tap the name, and significantly easier to tap the top message.

Before
Screenshot 2022-06-22 at 2 55 49 pm
After
Screenshot 2022-06-22 at 3 14 40 pm

(Width differences seen above are due to different size devices)

The height on bubbles has been reduced to 3pt so it exactly matches to the top of the bubble.

Bubbles
Screenshot 2022-06-22 at 3 36 10 pm

Fixes #4324

@sonarcloud
Copy link

sonarcloud bot commented Jun 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@aringenbach aringenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Taping first line Mention Pills was pretty hard indeed.

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/tAwaLd

@pixlwave pixlwave merged commit 7d0027e into develop Jun 23, 2022
@pixlwave pixlwave deleted the doug/4324-fix-name-tap-area branch June 23, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncomfortable tapping areas
2 participants