Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for account deactivation over SSO. #6252

Merged
merged 3 commits into from
Jun 9, 2022

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Jun 7, 2022

Account deactivation currently only works if the account was logged in using a password. This PR adds an AccountDeactivationService that handles the user interactive authentication using UserInteractiveAuthenticationService so that SSO (in particular SIWA) can be used to deactivate an account. Fixes #4685

One annoying caveat is that the fallback doesn't provide any indication of success so doesn't work inside of AuthFallbackViewController (you finish with a modal sitting there with Cancel and Back buttons). I've used an SFSafariViewController as that at least has a Done button for the user to tap when they've finished.

Deactivate-SIWA.mp4

Note: I've now removed the short period of time where the loading indicator disappeared in the recording.

@pixlwave pixlwave requested review from a team, SBiOSoftWhare, phloux and MaximeEvrard42 and removed request for a team and SBiOSoftWhare June 7, 2022 15:44
@github-actions
Copy link

github-actions bot commented Jun 7, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/we7MAd

Copy link
Contributor

@phloux phloux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the small issue with the changelog's file name, the other changes look good for me.

changelog.d/4658.bugfix Outdated Show resolved Hide resolved
@pixlwave pixlwave requested review from phloux, a team, MaximeEvrard42 and ismailgulek and removed request for MaximeEvrard42 and a team June 8, 2022 07:50
Copy link
Contributor

@ismailgulek ismailgulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this was a pain. Just minor comments, otherwise LGTM!

@pixlwave pixlwave requested a review from ismailgulek June 9, 2022 14:21
@pixlwave pixlwave merged commit 85db782 into develop Jun 9, 2022
@pixlwave pixlwave deleted the doug/4685_sso_deactivation branch June 9, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It's not possible to deactivate a Sign in with Apple account.
3 participants