-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for account deactivation over SSO. #6252
Conversation
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/we7MAd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except the small issue with the changelog's file name, the other changes look good for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this was a pain. Just minor comments, otherwise LGTM!
Account deactivation currently only works if the account was logged in using a password. This PR adds an
AccountDeactivationService
that handles the user interactive authentication usingUserInteractiveAuthenticationService
so that SSO (in particular SIWA) can be used to deactivate an account. Fixes #4685One annoying caveat is that the fallback doesn't provide any indication of success so doesn't work inside of
AuthFallbackViewController
(you finish with a modal sitting there withCancel
andBack
buttons). I've used anSFSafariViewController
as that at least has aDone
button for the user to tap when they've finished.Deactivate-SIWA.mp4
Note: I've now removed the short period of time where the loading indicator disappeared in the recording.