Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FTUE celebration screen #5891

Merged
merged 3 commits into from
Mar 22, 2022
Merged

Add FTUE celebration screen #5891

merged 3 commits into from
Mar 22, 2022

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Mar 22, 2022

Adds the final FTUE Celebration screen for #5651 with confetti being shown on this screen, or the Congratulations screen if personalisation isn't available (as the celebration screen won't be shown). This screen is currently disabled behind the onboardingShowAccountPersonalization build setting.

lightmode.mov
darkmode.mov
congrats.mov

@github-actions
Copy link

github-actions bot commented Mar 22, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/3WTLEt

Rename OnboardingConstants to OnboardingMetrics.
Fix strings warning about public property in public extension.
Remove unused OnboardingCelebrationViewModelResult.
@pixlwave pixlwave requested review from a team and gileluard and removed request for a team March 22, 2022 12:02
Copy link
Contributor

@gileluard gileluard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Special mention to your EffectsView 🎉 !

@pixlwave pixlwave merged commit ea44865 into develop Mar 22, 2022
@pixlwave pixlwave deleted the doug/5651_ftue_celebration branch March 22, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants