Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix avatars and hide spaces in Share Extension. #5062

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Fix avatars and hide spaces in Share Extension. #5062

merged 1 commit into from
Oct 29, 2021

Conversation

pixlwave
Copy link
Member

Fixes #5057.

  • Avatars were missing as the room cell data doesn't have an associated MXSession in the share extension, but it summary does (side effect of Fix generated avatar colours not matching Element Web. #4980 only visible on fresh installs).
  • Rooms are now filtered to only show room types so that spaces are now hidden.

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/x5cbSH

@stefanceriu stefanceriu merged commit baef854 into develop Oct 29, 2021
@stefanceriu stefanceriu deleted the doug/5057_share_extension_room_list branch October 29, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanceriu stefanceriu stefanceriu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avatars are missing in Share Extension and Spaces are being listed too.
2 participants
@pixlwave @stefanceriu