Show encrypted message notification content by default. #4530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So do I have this correct?
|
|
From reading the other PR and the code a bit more clears it up. |
langleyd
approved these changes
Jul 9, 2021
There was a problem hiding this comment.
Code changes look good to me. As @gileluard mentioned a BuildSetting could be useful for PS/Customers. And also double checking design/product sign off on the changed behaviour.
|
BuildSetting added 👍 |
…t_fix # Conflicts: # CHANGES.rst # Config/BuildSettings.swift
pixlwave
force-pushed
the
doug/4519_decrypt_notifications_by_default
branch
from
8c64209 to
6229055
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the "Show decrypted content" notification setting by default on first run of a fresh install.
Fixes #4519.
Note related: matrix-org/matrix-ios-kit#846