Crypto: Key sharing: Move the check of incoming key requests so that … #1655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…we can detect them at app startup. element-hq/riot-meta#121 This is now required because, with matrix-org/matrix-ios-sdk#414, key requests can be available when app starts.
giomfo
approved these changes
Nov 16, 2017
| if (mxSession.state == MXSessionStateRunning) | ||
| { | ||
| // Check if we need to display a key share dialog | ||
| [self checkPendingRoomKeyRequests]; |
There was a problem hiding this comment.
You already check [[UIApplication sharedApplication] applicationState] inside the checkPendingRoomKeyRequests method
There was a problem hiding this comment.
true but if you look at the whole state machine management where this piece of code sits, it appears natural to check the UIApplicationStateActive case at this moment.
At least, this is what I feel, no?
There was a problem hiding this comment.
I understood, but we already know here that the applicationState is not background...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…we can detect them at app startup.
element-hq/riot-meta#121
This is now required because, with matrix-org/matrix-ios-sdk#414, key requests can be available when app starts.