Update Cocoapods and reduce Riot/OLM coupling #1220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hberenger
commented
May 9, 2017
hberenger
commented
- Update Cocoapods version to benefit from bug fixes.
- Uncouple Riot from OLM by retrieving the OLM version from MatrixSDK instead of OLM.
added 2 commits
May 9, 2017 18:18
Move the OLM version info string from "Other" to "Cryptography" section. The only direct call made to the OLM library from the main Riot codeline (pods excluded) consists in retrieving the OLM version string. By moving the OLM version info into the "Cryptography" section, we are allowed to retrieve it from the MxSession instead. This reduces the coupling betw. Riot and OLM (in fact it makes Riot uncoupled from OLM).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.