Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong copy for upgrade room message #5997

Closed
gileluard opened this issue Apr 6, 2022 · 0 comments · Fixed by #6003
Closed

Wrong copy for upgrade room message #5997

gileluard opened this issue Apr 6, 2022 · 0 comments · Fixed by #6003
Assignees
@gileluard
Labels
A-Spaces Spaces, groups, communities S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@gileluard
Copy link
Contributor

Steps to reproduce

Here is the actual copy:
https://github.com/vector-im/element-ios/blob/ce38eb853fbed11d532abc633dc2b75bf7060953/Riot/Assets/en.lproj/Vector.strings#L925

Here is the android one:
https://github.com/vector-im/element-android/blob/main/vector/src/main/res/values/strings.xml#L2895

Outcome

What did you expect?

the copy should be dynamic

What happened instead?

"Space name" is hardcoded.

Your phone model

No response

Operating system version

No response

Application version

No response

Homeserver

No response

Will you send logs?

No
@gileluard gileluard added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Apr 6, 2022
@gileluard gileluard added A-Spaces Spaces, groups, communities S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Apr 6, 2022
@gileluard gileluard self-assigned this Apr 6, 2022
@gileluard gileluard mentioned this issue Apr 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gileluard gileluard

Labels
A-Spaces Spaces, groups, communities S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Wrong copy for upgrade room message element-hq/element-ios
1 participant
@gileluard