Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth argument in /register request is not spec compliant #3736

Closed
timokoesters opened this issue Oct 9, 2020 · 8 comments · Fixed by #5510
Closed

auth argument in /register request is not spec compliant #3736

timokoesters opened this issue Oct 9, 2020 · 8 comments · Fixed by #5510

Comments

@timokoesters
Copy link

Element Web had the same issue: matrix-org/matrix-react-sdk#4347

@aaronraimist
Copy link
Contributor

Just adding a keyword for search: conduit

@timokoesters
Copy link
Author

This should be fairly easy to fix. It only required changing a single line on Element Web.

I don't really know anything about the codebase and don't have an ios device to test with. Maybe the bug is here somewhere?: https://github.com/matrix-org/matrix-ios-sdk/blob/51af49ac3765a14f2294710b4952e89de19ec42c/MatrixSDK/MXRestClient.m#L402

@itsjunetime
Copy link

Possibly here in MatrixKit? I'm not very knowledgeable about this issue/spec, but that seems to be the only place that the auth parameter in a register request is empty, so simply removing it from the dictionary may do the trick.

I'd have no idea how to test this, though, so I can't say for certain if it would fix the issue.

@kragil
Copy link

kragil commented Jul 12, 2021

Why isn't this getting fixed?

@ashton314
Copy link

👉🏼 poke

I think this is still an issue, yes?

@kragil
Copy link

kragil commented Sep 10, 2021

Yes, it is AFAICT.

@timokoesters
Copy link
Author

This is still a problem. It should even be easy to fix because you only have to stop sending the "auth" dict. See the linked issue on matrix-react-sdk:

In that spec version it says that auth shouldn't be auth: {} but rather not be present.

@ovidiu-ionescu
Copy link

Maybe as an interim step, display an extra friendlier message. Business people get the impression Element does not work at all on ios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants