Crash when hitting a room header after some special steps

[jeangb]

To reproduce:

1. Open a room, keep in mind some message of the list
2. Hit the search button, launch a search with the message from step 1
3. Hit the found message item
4. Hit the go to bottom arrow
5. Expand the room header
6. Hit the room header (in the empty zone)

Systematic crash

[manuroe]

Same crash with a call stack: https://github.com/matrix-org/riot-ios-rageshakes/issues/76

Main thread: YES
(
	0   CoreFoundation                      0x000000019283eff8 <redacted> + 148
	1   libobjc.A.dylib                     0x00000001912a0538 objc_exception_throw + 56
	2   UIKit                               0x0000000198cd7f28 <redacted> + 0
	3   Riot                                0x0000000100147f7c -[RoomViewController roomTitleView:recognizeTapGesture:] + 1288
	4   Riot                                0x000000010019dcf4 -[RoomTitleView reportTapGesture:] + 152
	5   UIKit                               0x0000000198f41d38 <redacted> + 64
	6   UIKit                               0x0000000198f4556c <redacted> + 124
	7   UIKit                               0x0000000198aff470 <redacted> + 252
	8   UIKit                               0x00000001989a1380 <redacted> + 720
	9   UIKit                               0x0000000198f35810 <redacted> + 988
	10  UIKit                               0x0000000198f353e0 <redacted> + 404
	11  UIKit                               0x0000000198f3468c <redacted> + 268
	12  UIKit                               0x000000019899f70c <redacted> + 3164
	13  UIKit                               0x000000019897033c <redacted> + 340
	14  UIKit                               0x000000019916a014 <redacted> + 2400
	15  UIKit                               0x0000000199164770 <redacted> + 4268
	16  UIKit                               0x0000000199164b9c <redacted> + 148
	17  CoreFoundation                      0x00000001927ed42c <redacted> + 24
	18  CoreFoundation                      0x00000001927ecd9c <redacted> + 540
	19  CoreFoundation                      0x00000001927ea9a8 <redacted> + 744
	20  CoreFoundation                      0x000000019271ada4 CFRunLoopRunSpecific + 424
	21  GraphicsServices                    0x0000000194184074 GSEventRunModal + 100
	22  UIKit                               0x00000001989d5058 UIApplicationMain + 208
	23  Riot                                0x0000000100158610 main + 184
	24  libdyld.dylib                       0x000000019172959c <redacted> + 4
)

[manuroe]

Step 5 can be skipped.
It is probably because we reload everything on step 4 and the delegate of [RoomTitleView reportTapGesture:] is probably wrong.

[giomfo]

The crash is due to the fact that the screen used to display the room history from the search result was not able to show room details screen (no segue with identifier 'showRoomDetails' was defined yet).
Because the user may now switch in live mode the room history, we just have to define this segue...

[giomfo]

@jeangb fixed

[jeangb]

Validated in #1961.