Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Left rooms are still displayed in breadcrumbs #766

Closed
bmarty opened this issue Dec 11, 2019 · 4 comments
Closed

Left rooms are still displayed in breadcrumbs #766

bmarty opened this issue Dec 11, 2019 · 4 comments
Assignees
@bmarty
Labels
A-Breadcrumbs

Comments

@bmarty
Copy link
Member

bmarty commented Dec 11, 2019

No description provided.

@BillCarsonFr
Copy link
Member

See element-hq/element-web#11644

@bmarty
Copy link
Member Author

bmarty commented Dec 13, 2019

So it's a feature, because you can eventually re-join the left room :)

@steef435
Copy link

Currently, the breadcrumb items of left rooms also get a green "new notifications" bar. Even though a design decision has to be made on whether they should stick or not after leaving the room, could those highlights be removed in any case?

@bmarty bmarty self-assigned this Jun 4, 2020
bmarty added a commit that referenced this issue Jun 4, 2020
@bmarty
Hide left rooms in breadcrumbs (#766)
a3fd494
bmarty added a commit that referenced this issue Jun 4, 2020
@bmarty
Merge pull request #1446 from vector-im/feature/various_fixes
2e244dd 
Hide left rooms in breadcrumbs (#766)
@bmarty
Copy link
Member Author

bmarty commented Aug 5, 2020

Fixed in #1446

@bmarty bmarty closed this as completed Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmarty bmarty

Labels
A-Breadcrumbs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@steef435 @bmarty @BillCarsonFr