#2028 did not fix a test in Complement

[matrixbot]

This issue was originally created by @ShadowJonathan at matrix-org/dendrite#2800.

While going over the Complement codebase, I found the following line;

https://github.com/matrix-org/complement/blob/0e88861054556a734f40d5754d93499a7ac311c1/tests/federation_room_join_test.go#L203

It mentions #2028, but when I ran the test with a latest Dendrite version, the test failed;

Test Log

2022/10/16 13:07:55 config: &{BaseImageURI:complement-dendrite:latest DebugLoggingEnabled:false AlwaysPrintServerLogs:false EnvVarsPropagatePrefix: SpawnHSTimeout:30s KeepBlueprints:[] HostMounts:[] BaseImageURIs:map[] PackageNamespace:fed CACertificate:0x14000d96000 CAPrivateKey:0x1400009c300 BestEffort:false HostnameRunningComplement:host.docker.internal}
=== RUN   TestJoinFederatedRoomWithUnverifiableEvents
    federation_room_join_test.go:104: Deploy times: 2.515984417s blueprints, 794.11175ms containers
    client.go:604: [CSAPI] GET hs1/_matrix/client/v3/capabilities => 200 OK (16.988458ms)
=== CONT  TestJoinFederatedRoomWithUnverifiableEvents
    server.go:103: Server.UnexpectedRequestsAreErrors=false received unexpected request to server: GET /_matrix/federation/v1/event/$FjhukbbD26N3rUqH2lzKngZbEM1jAeAhxlu3dncitWg - sending 404 which may cause the HS to backoff from Complement
    server.go:103: Server.UnexpectedRequestsAreErrors=false received unexpected request to server: GET /_matrix/federation/v1/event_auth/!0-T49tVacNkkjfgvIdX6:host.docker.internal:63974/$C5trg_NJeaVRTbV-8BBEX19C74LPseQixCsvpkEMkG0 - sending 404 which may cause the HS to backoff from Complement
    client.go:604: [CSAPI] POST hs1/_matrix/client/v3/join/#UnverifiableAuthEvents:host.docker.internal:63974 => 500 Internal Server Error (141.263291ms)
--- FAIL: TestJoinFederatedRoomWithUnverifiableEvents (6.42s)
=== RUN   TestJoinFederatedRoomWithUnverifiableEvents//send_join_response_with_state_with_unverifiable_auth_events_shouldn't_block_room_join
    federation_room_join_test.go:203: WARNING: TestJoinFederatedRoomWithUnverifiableEvents//send_join_response_with_state_with_unverifiable_auth_events_shouldn't_block_room_join called runtime.SkipIf([dendrite]) but Complement doesn't know which HS is running as it was run without a *_blacklist tag: executing test.
    server.go:170: Creating room !0-T49tVacNkkjfgvIdX6:host.docker.internal:63974 with version 9
    federation_room_join_test.go:228: Created badly signed auth event $FjhukbbD26N3rUqH2lzKngZbEM1jAeAhxlu3dncitWg
    federation_room_join_test.go:251: Created state event $C5trg_NJeaVRTbV-8BBEX19C74LPseQixCsvpkEMkG0
2022/10/16 13:08:00 Received send-join of event $ozX32szDiVmi-EWhhQ4cDgNuSbfJoP0p_GA5jd2mV5Y
=== CONT  TestJoinFederatedRoomWithUnverifiableEvents//send_join_response_with_state_with_unverifiable_auth_events_shouldn't_block_room_join
    federation_room_join_test.go:253: CSAPI.MustDoFunc response return non-2xx code: 500 Internal Server Error - body: {"message":"roomserverAPI.SendEventWithState: InputRoomEventsResponse: r.fetchAuthEvents: no servers provided event auth for event ID \"$C5trg_NJeaVRTbV-8BBEX19C74LPseQixCsvpkEMkG0\", tried servers [host.docker.internal:63974]"}

I'm making this issue to make note of this, that #2028 might not have fixed the issue as it appeared to be.

[matrixbot]

This comment was originally posted by @kegsay at matrix-org/dendrite#2800 (comment).

Thanks, reopening #2028