Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure that identical types in set/get are deduper from ctor #243

Merged
merged 1 commit into from
Oct 2, 2023
Merged

fix: ensure that identical types in set/get are deduper from ctor #243

merged 1 commit into from
Oct 2, 2023

Conversation

MarshallOfSound
Copy link
Member

This PR does two things to ensure type deduplication:

  • Constructor types are declared first so their is a baseline for setters/getters to be compared too
  • Type dedupe logic now ignores descriptions so that the wording doesn't have to be identical in the docs

@MarshallOfSound MarshallOfSound requested review from a team as code owners September 11, 2023 10:10
@codebytere codebytere merged commit 64c58c7 into main Oct 2, 2023
3 checks passed
@codebytere codebytere deleted the dedupe-ctor branch October 2, 2023 09:17
@continuous-auth
Copy link

🎉 This PR is included in version 8.14.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarshallOfSound @jkleinsc @codebytere