Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not prefix promise inner types #227

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Conversation

MarshallOfSound
Copy link
Member

4 year old code, can't explain why we need it, it breaks things, let's delete it

@MarshallOfSound MarshallOfSound requested review from a team as code owners March 6, 2023 23:11
Copy link
Member

@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love to see it

@MarshallOfSound MarshallOfSound merged commit 9560079 into main Mar 6, 2023
@MarshallOfSound MarshallOfSound deleted the no-promise-prefix branch March 6, 2023 23:12
@continuous-auth
Copy link

🎉 This PR is included in version 8.14.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

MarshallOfSound added a commit that referenced this pull request Jun 12, 2023
MarshallOfSound added a commit that referenced this pull request Jun 12, 2023
* Revert "fix: do not prefix promise inner types (#227)"

This reverts commit 9560079.

* fix: prefix promise types where appropriate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants