Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with Electron v28. #177

Closed
tr-takatsuka opened this issue Dec 11, 2023 · 2 comments
Closed

Does not work with Electron v28. #177

tr-takatsuka opened this issue Dec 11, 2023 · 2 comments

Comments

@tr-takatsuka
Copy link

tr-takatsuka commented Dec 11, 2023

Nice to meet you. I am a user of electron-remoto.

Electron 28 has been released and when I tried it, I could not get it to work.

customEvent.returnValue = process.mainModule.require(moduleName);

customEvent.returnValue = process.mainModule!.require(moduleName)

It seems that process.mainModule is obsolete and an error occurs at this point.

I tried changing to use require.main as a trial,
but require.main became undefined.

Is it working properly with Electron 28 at your place?

Thank you and best regards.

@tr-takatsuka
Copy link
Author

Sorry, I just realised that the topic had already been discussed.
#171

@Kilian
Copy link
Member

Kilian commented Dec 11, 2023

closing to keep this in #171

@Kilian Kilian closed this as completed Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants