Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: upgrade electron-osx-sign to @electron/osx-sign #1428

Merged
merged 2 commits into from
Oct 18, 2022

Conversation

MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented Oct 12, 2022

BREAKING CHANGE: This changes the accepted options for the osxSign option.

TODO:

  • Write the to-be-linked migration guide

BREAKING CHANGE: This changes the accepted options for the `osxSign` option.
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #1428 (62f9413) into main (c02695f) will increase coverage by 0.62%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1428      +/-   ##
==========================================
+ Coverage   94.85%   95.47%   +0.62%     
==========================================
  Files          15       15              
  Lines         777      774       -3     
==========================================
+ Hits          737      739       +2     
+ Misses         40       35       -5     
Impacted Files Coverage Δ
src/mac.js 99.41% <100.00%> (+2.30%) ⬆️
src/copy-filter.js 100.00% <0.00%> (+2.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@erickzhao erickzhao self-requested a review October 12, 2022 18:05
@VerteDinde VerteDinde changed the title feat: upgrade electron-osx-sign to @electron/osx-sign feat!: upgrade electron-osx-sign to @electron/osx-sign Oct 18, 2022
@erickzhao erickzhao merged commit 274c686 into main Oct 18, 2022
@erickzhao erickzhao deleted the upgrade-osx-sign branch October 18, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants