From bed9eb9a15b2ff29b61be6056796266d5f792d32 Mon Sep 17 00:00:00 2001 From: Erick Zhao Date: Thu, 20 Oct 2022 15:45:20 -0700 Subject: [PATCH] ci: clean up ci config (#116) * style: run Prettier * docs: uniformize badge styles * ci: upgrade jobs to Node 18 LTS --- .circleci/config.yml | 4 ++-- README.md | 2 +- src/spawn.ts | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 069a345..218cd3a 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -2,7 +2,7 @@ version: 2 jobs: test: docker: - - image: circleci/node:12 + - image: cimg/node:18.11.0 steps: - checkout - restore_cache: @@ -16,7 +16,7 @@ jobs: - run: yarn test release: docker: - - image: circleci/node:10 + - image: cimg/node:18.11.0 steps: - checkout - restore_cache: diff --git a/README.md b/README.md index e4c2db6..deb3b43 100644 --- a/README.md +++ b/README.md @@ -3,7 +3,7 @@ Electron Notarize > Notarize your Electron apps seamlessly for macOS -[![CircleCI status](https://circleci.com/gh/electron/electron-notarize.svg?style=svg)](https://circleci.com/gh/electron/electron-notarize) +[![CircleCI status](https://circleci.com/gh/electron/electron-notarize.svg?style=shield)](https://circleci.com/gh/electron/electron-notarize) [![NPM package](https://img.shields.io/npm/v/electron-notarize)](https://npm.im/electron-notarize) ## Installation diff --git a/src/spawn.ts b/src/spawn.ts index 0558018..0e91f24 100644 --- a/src/spawn.ts +++ b/src/spawn.ts @@ -28,7 +28,7 @@ export const spawn = ( child.stdout!.on('data', dataHandler); child.stderr!.on('data', dataHandler); return new Promise((resolve, reject) => { - child.on('error', (err) => { + child.on('error', err => { reject(err); }); child.on('exit', code => {