perf_hooks: clean up GC listeners (#94)

Add Environment cleanup hooks to remove GC listeners when the `Environment` is torn down. PR-URL: nodejs/node#25647 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
electron · Mar 5, 2019 · f807d72 · f807d72
1 parent 70a78f0
commit f807d72
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/node_perf.cc b/src/node_perf.cc
@@ -296,6 +296,11 @@ inline void SetupGarbageCollectionTracking(Environment* env) {
                                         static_cast<void*>(env));
   env->isolate()->AddGCEpilogueCallback(MarkGarbageCollectionEnd,
                                         static_cast<void*>(env));
+  env->AddCleanupHook([](void* data) {
+    Environment* env = static_cast<Environment*>(data);
+    env->isolate()->RemoveGCPrologueCallback(MarkGarbageCollectionStart, data);
+    env->isolate()->RemoveGCEpilogueCallback(MarkGarbageCollectionEnd, data);
+  }, env);
 }
 
 // Gets the name of a function