feat!: add support for WSL2 #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Drops support for Node < 10
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Thanks! Haven't tested it yet but it looks sound to outsource that logic. |
Turns out the logic is also needed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for WSL2 while at the same time fixing all known issues with WSL1 support. Uses a new module,
cross-spawn-windows-exe, to executercedit.execorrectly in any given environment (including WSL1/WSL2). It should be noted that the module itself is tested in CI with WSL1, so I decided not to add it here.Since the new module requires Node 10, I updated any other (dev)Dependencies that also require Node 10.
BREAKING CHANGE: requires Node 10 (drops support for Node < 10).
Fixes #65.
Closes #66.