Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for svelte kit #3309

Closed
3 tasks done
mmm8955405 opened this issue Aug 21, 2023 · 7 comments
Closed
3 tasks done

Support for svelte kit #3309

mmm8955405 opened this issue Aug 21, 2023 · 7 comments
Labels
blocked/needs-info Issues lacking information for resolution bug

Comments

@mmm8955405
Copy link

Pre-flight checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project uses.
  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Problem description

Due to this cmd file forge. config. js, the svelte kit cannot be supported

Proposed solution

No documents found

Alternatives considered

No documents found

Additional information

No response

@erickzhao
Copy link
Member

Due to this cmd file forge. config. js, the svelte kit cannot be supported

Can you elaborate?

@erickzhao erickzhao added bug blocked/needs-info Issues lacking information for resolution labels Aug 21, 2023
@mmm8955405
Copy link
Author

mmm8955405 commented Aug 22, 2023

This is an example of integrating the svelte kit。
It has been unable to run since last year. The reason is ‘forge. config. js’ is a commonJS
https://github.com/jjiii/client

@mmm8955405
Copy link
Author

I have tried almost all methods, but they have all failed. Through electron forge+sveltekit.

@caoxiemeihao
Copy link
Member

- svelte.config.js
+ svelte.config.mjs
image
  • TODO: support use esm in the forge.config.js

@mmm8955405
Copy link
Author

- svelte.config.js
+ svelte.config.mjs
image * [ ] TODO: support use `esm` in the `forge.config.js`

It really works, thank you very much

@dominikg
Copy link

note that sveltekit does not support using svelte.config.mjs

https://github.com/sveltejs/kit/blob/e54d56ed34a00296270342c87ef9ec908251c4ba/packages/kit/src/core/config/index.js#L64

without testing what happens here my hunch is that sveltekit would start, but run with default configuration, same as if you don't have a svelte.config.js at all.

using "type": "commonjs" in the project package.json is not supported by sveltekit, see also https://kit.svelte.dev/docs/project-structure#project-files-package-json

@caoxiemeihao
Copy link
Member

caoxiemeihao commented Jan 18, 2024

note that sveltekit does not support using svelte.config.mjs

@dominikg 👋 Thx for your reminder.

Since electrono@28 version, "type": "module" has been supported.

@caoxiemeihao caoxiemeihao linked a pull request Feb 3, 2024 that will close this issue
5 tasks
@caoxiemeihao caoxiemeihao removed a link to a pull request Feb 3, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked/needs-info Issues lacking information for resolution bug
Projects
None yet
Development

No branches or pull requests

4 participants