-
-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snapcraft builds are always auto rejected #1678
Comments
Closing in favor of electron-userland/electron-installer-snap#74 |
@malept wherever the issue should live, the problem exists in both places and will have to be documented. Do you have any feedback here on how to fix this? |
It's still a duplicate issue and it's linked so I don't see a problem with marking this as duplicate and closing it.
I would need to make some time to investigate this, although I maintain this in my very limited free time, so I don't know when that will be. For the record, the reasons for enabling browser sandbox for Electron >= 5.0.0 is documented here: electron-userland/electron-installer-snap#22 |
@malept I see in that PR you linked part of the changes added a console.warn saying I see that the PR says this was implemented to support electron/electron#17269, but is sandbox required for Electron apps to run at all on Linux? I am still confused why this is the default with no options to disable it. |
Reopening this to review/make some snap improvements |
@VerteDinde I'm using https://github.com/davidwinter/electron-forge-maker-snap to get snap to work, since the base lib didn't support it |
This was fixed upstream in |
Preflight Checklist
Issue Details
Expected Behavior
The created snapcraft files should be able to be uploaded and pass review.
Actual Behavior
The snap builds always fail the automatic review and are rejected with this:
To Reproduce
Additional Information
I have read in a bunch of places to use
--no-sandbox
which I am doing with this:I have also tried setting
browserSandbox: false
in the forge config. My current config:Is there a way to get this to work?
The text was updated successfully, but these errors were encountered: