Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve matchMedia mocking #1655

Merged
merged 1 commit into from
Nov 28, 2024
Merged

test: improve matchMedia mocking #1655

merged 1 commit into from
Nov 28, 2024

Conversation

dsanders11
Copy link
Member

With better mocking we can remove if (!!window.matchMedia) in the code, which was only there because the mock wasn't defined for all tests.

@coveralls
Copy link

Coverage Status

coverage: 87.595% (-0.009%) from 87.604%
when pulling aa3fee7 on test/improve-matchMedia-test
into 0c7e997 on main.

@dsanders11 dsanders11 marked this pull request as ready for review November 27, 2024 22:42
@dsanders11 dsanders11 requested review from codebytere and a team as code owners November 27, 2024 22:42
@BlackHole1 BlackHole1 merged commit 5232b60 into main Nov 28, 2024
10 checks passed
@BlackHole1 BlackHole1 deleted the test/improve-matchMedia-test branch November 28, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlackHole1 BlackHole1 BlackHole1 approved these changes

@codebytere codebytere Awaiting requested review from codebytere codebytere is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsanders11 @coveralls @BlackHole1