Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mark fiddle as edited if files added/deleted #1475

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Conversation

dsanders11
Copy link
Member

Currently adding or deleting a file doesn't count as editing a fiddle which can lead to non-ideal behavior like adding a file without content and then switching selected versions and having the file disappear, or deleting a file and then closing the window and not being prompted to save.

@coveralls
Copy link

Coverage Status

coverage: 87.37% (+0.004%) from 87.366% when pulling f444bff on fix-edited into 68d9c98 on main.

@dsanders11 dsanders11 marked this pull request as ready for review October 3, 2023 20:08
@dsanders11 dsanders11 requested review from codebytere and a team as code owners October 3, 2023 20:08
@dsanders11 dsanders11 merged commit e7b7ac9 into main Oct 4, 2023
4 checks passed
@dsanders11 dsanders11 deleted the fix-edited branch October 4, 2023 02:44
@aabdoaa
Copy link

aabdoaa commented Nov 9, 2023

Currently adding or deleting a file doesn't count as editing a fiddle which can lead to non-ideal behavior like adding a file without content and then switching selected versions and having the file disappear, or deleting a file and then closing the window and not being prompted to save.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants