Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: convert Forge and Webpack config to TypeScript #1406

Merged
merged 2 commits into from
Jul 18, 2023
Merged

build: convert Forge and Webpack config to TypeScript #1406

merged 2 commits into from
Jul 18, 2023

Conversation

dsanders11
Copy link
Member

TypeScript all the things.

@dsanders11 dsanders11 requested review from a team and codebytere as code owners July 18, 2023 02:24
erickzhao
erickzhao approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool CI passes :shipit:

@dsanders11 dsanders11 merged commit 7226571 into main Jul 18, 2023
@dsanders11 dsanders11 deleted the typescript-forge branch July 18, 2023 18:59
@dsanders11 dsanders11 mentioned this pull request Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzhao erickzhao erickzhao approved these changes

@codebytere codebytere Awaiting requested review from codebytere codebytere is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsanders11 @erickzhao