fix: handle null/undefined options for fs.readdir #34764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
reviewed
Jul 13, 2022
|
Looks like webpack/webpack#10227 - we can probably fix this but yeah let's do it in another PR! |
3 tasks
codebytere
force-pushed
the
fs-wrapper-readdir
branch
from
cb218b0
to
2bd8586
Compare
ckerr
added
semver/patch
ckerr
approved these changes
Sep 16, 2022
|
@dsanders11 patch LGTM, but needs an update to resolve merge conflicts |
dsanders11
force-pushed
the
fs-wrapper-readdir
branch
from
2bd8586
to
9acce51
Compare
nornagon
approved these changes
Nov 30, 2022
|
Release Notes Persisted
|
trop bot
added a commit
that referenced
this pull request
Jan 10, 2023
Co-authored-by: David Sanders <[email protected]>
trop bot
added a commit
that referenced
this pull request
Jan 10, 2023
Co-authored-by: David Sanders <[email protected]>
This was referenced Jan 10, 2023
|
I have automatically backported this PR to "21-x-y", please check out #36846 |
trop
bot
added
in-flight/21-x-y
and removed
target/21-x-y
|
I have automatically backported this PR to "20-x-y", please check out #36847 |
|
I have automatically backported this PR to "23-x-y", please check out #36848 |
|
I have automatically backported this PR to "22-x-y", please check out #36849 |
trop
bot
added
in-flight/23-x-y
merged/22-x-y
codebytere
pushed a commit
that referenced
this pull request
Jan 11, 2023
fix: handle null/undefined options for fs.readdir (#34764) Co-authored-by: David Sanders <[email protected]> Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: David Sanders <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jan 11, 2023
fix: handle null/undefined options for fs.readdir (#34764) Co-authored-by: David Sanders <[email protected]> Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: David Sanders <[email protected]>
trop
bot
added
merged/23-x-y
dsanders11
added a commit
that referenced
this pull request
Jan 19, 2023
Co-authored-by: David Sanders <[email protected]>
trop
bot
added
merged/21-x-y
zcbenz
pushed a commit
that referenced
this pull request
Jan 23, 2023
* fix: handle null/undefined options for fs.readdir (#34764) Co-authored-by: David Sanders <[email protected]> * chore: remove optional chaining Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: David Sanders <[email protected]>
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
gecko19
pushed a commit
to brightsign/electron
that referenced
this pull request
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes isaacs/node-graceful-fs#223 in Electron. I also have a PR on that repo to improve their behavior (which would also fix the issue), so I'm fixing it from all angles.
This moves
fs.readdirslightly closer to the typings from Node, but there's still other issues (optionscould be a string). I plan on doing a more general improvement PR to fix up behavior inlib/asar/fs-wrapper.ts.Checklist
npm testpassesRelease Notes
Notes: Fixed an error when fs.readdir gets null for options