Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: escape src dir while crawling fs #68

Conversation

demetris-manikas
Copy link

Solves situations where the directory name is like "pa[ck]this"

@develar
Copy link

develar commented May 24, 2016

glob is not a regexp. So, using escape-string-regexp is not fully correct.

Also, what electron-packager want — just ask pack the whole dir. It is not expected that path will be as a pattern.

So, I don't like current solution — we don't need to fight against asar/glob. Instead, should be a way to disable glob. And use path just as path, not as a pattern.

cc: @malept

@develar
Copy link

develar commented May 24, 2016

@demetris-manikas demetris-manikas deleted the FIX-crawlfs-escape-src-dir branch June 6, 2016 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants