Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS compilation issues with version 3.2.11 compared to 3.2.10. #324

Closed
bmk-m opened this issue Sep 10, 2024 · 3 comments
Closed

TS compilation issues with version 3.2.11 compared to 3.2.10. #324

bmk-m opened this issue Sep 10, 2024 · 3 comments

Comments

@bmk-m
Copy link

bmk-m commented Sep 10, 2024

Error:
node_modules/@types/glob/index.d.ts(29,42): error TS2694: Namespace '"node_modules/minimatch/dist/commonjs/index"' has no exported member 'IOptions'. node_modules/@types/glob/index.d.ts(74,30): error TS2724: '"node_modules/minimatch/dist/commonjs/index"' has no exported member named 'IMinimatch'. Did you mean 'Minimatch'? node_modules/minimatch/dist/commonjs/ast.d.ts(4,5): error TS18028: Private identifiers are only available when targeting ECMAScript 2015 and higher.

Seems to be caused by the newest changes adding back @types/gob back to package.json in this commit: 88b5ea4#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519

It was previously removed in this commit for this particular issue: df7991c

@types/glob is unmaintained and really should be a devDep and not an actual dependency. This is the ticket in the past that spurred the commit right above: #266

@emeryao
Copy link

emeryao commented Sep 14, 2024

+1

same here

@emeryao
Copy link

emeryao commented Sep 17, 2024

install the package of @electron/asar@^3.2.13 explicitly in package.json seems fix this issue for my project

@erickzhao
Copy link
Member

erickzhao commented Sep 17, 2024

Hi, we had a few kinks in the build pipeline after the full TypeScript rewrite. Please upgrade to 3.2.13 at your earliest convenience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants