Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SASS partials are compiled on make #182

Closed
3 tasks done
ajimix opened this issue Mar 25, 2017 · 4 comments · May be fixed by electron-userland/electron-compilers#81
Closed
3 tasks done

SASS partials are compiled on make #182

ajimix opened this issue Mar 25, 2017 · 4 comments · May be fixed by electron-userland/electron-compilers#81
Labels
blocked/upstream Issues blocked by upstream bugs

Comments

@ajimix
Copy link

ajimix commented Mar 25, 2017

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Please describe your issue:
When using sass partials electron-forge start works properly but electron-forge make prints some errors as it seems to try to compile the partials as well as the main files.
Note: the make process finish successfully althought the errors appear.

Console output when you run electron-forge with the environment variable DEBUG=electron-forge:*. (Instructions on how to do so here). Please include the stack trace if one exists.

WARNING: DEBUG environment variable detected.  Progress indicators will be sent over electron-forge:lifecycle
  electron-forge:lifecycle Process Started: Checking your system +0ms
  electron-forge:lifecycle Process Succeeded: Checking your system +20ms
  electron-forge:runtime-config setting key: verbose to value: false +11ms
WARNING: DEBUG environment variable detected.  Progress indicators will be sent over electron-forge:lifecycle
  electron-forge:lifecycle Process Started: Resolving Forge Config +0ms
  electron-forge:project-resolver searching for project in: /Users/adria/Desktop/test +2ms
  electron-forge:project-resolver electron-forge compatible package.json found in /Users/adria/Desktop/test/package.json +7ms
  electron-forge:lifecycle Process Succeeded: Resolving Forge Config +6ms
We need to package your application before we can make it
  electron-forge:lifecycle Process Started: Preparing to Package Application for arch: x64 +2ms
  electron-forge:project-resolver searching for project in: /Users/adria/Desktop/test +0ms
  electron-forge:project-resolver electron-forge compatible package.json found in /Users/adria/Desktop/test/package.json +0ms
  electron-forge:packager packaging with options { asar: false,
  overwrite: true,
  afterCopy: [ [Function], [Function], [Function], [Function] ],
  afterExtract: [],
  dir: '/Users/adria/Desktop/test',
  arch: 'x64',
  platform: 'darwin',
  out: '/Users/adria/Desktop/test/out',
  electronVersion: '1.6.2',
  quiet: true } +3ms
  electron-forge:lifecycle Process Succeeded: Preparing to Package Application for arch: x64 +7s
  electron-forge:lifecycle Process Started: Compiling Application +3ms
Failed to compile file: /var/folders/k1/m83wbd_x1vl_0wxjdh_bpm7m0000gn/T/electron-packager/darwin-x64/test-darwin-x64/Electron.app/Contents/Resources/app/src/_otherfile.scss
Error: Undefined variable: "$someColor".
        on line 2 of /stdin
>>   background-color: $someColor;
   --------------------^

  electron-forge:lifecycle Process Succeeded: Compiling Application +2s
  electron-forge:lifecycle Process Started: Preparing native dependencies +1ms
  electron-forge:lifecycle Process Succeeded: Preparing native dependencies +68ms
  electron-forge:lifecycle Process Started: Packaging Application +0ms
  electron-forge:lifecycle Process Succeeded: Packaging Application +6s
Making for the following targets:
  electron-forge:lifecycle Process Started: Making for target: zip - On platform: darwin - For arch: x64 +4ms
  electron-forge:require-search searching [ '../makers/darwin/zip.js',
  '../makers/generic/zip.js',
  'electron-forge-maker-zip',
  'zip',
  '/Users/adria/Desktop/test/zip',
  '/usr/local/lib/node_modules/electron-forge/dist/makers/darwin/zip.js',
  '/usr/local/lib/node_modules/electron-forge/dist/makers/generic/zip.js',
  '/usr/local/lib/node_modules/electron-forge/dist/api/electron-forge-maker-zip',
  '/usr/local/lib/node_modules/electron-forge/dist/api/zip',
  '/Users/adria/Desktop/test/zip',
  '/usr/local/lib/node_modules/electron-forge/dist/api/makers/darwin/zip.js',
  '/usr/local/lib/node_modules/electron-forge/dist/api/makers/generic/zip.js',
  '/usr/local/lib/node_modules/electron-forge/dist/api/node_modules/electron-forge-maker-zip',
  '/usr/local/lib/node_modules/electron-forge/dist/api/node_modules/zip',
  '/Users/adria/Desktop/test/zip' ] relative to /usr/local/lib/node_modules/electron-forge/dist/api +0ms
  electron-forge:require-search testing ../makers/darwin/zip.js +2ms
  electron-forge:require-search testing ../makers/generic/zip.js +1ms
  electron-forge:lifecycle Process Succeeded: Making for target: zip - On platform: darwin - For arch: x64 +8s

What command line arguments are you passing?
This is what I'm running:

DEBUG=electron-forge:* electron-forge make

What does your config.forge data in package.json look like?
Default, I haven't changed anything.

 "config": {
    "forge": {
      "make_targets": {
        "win32": [
          "squirrel"
        ],
        "darwin": [
          "zip"
        ],
        "linux": [
          "deb",
          "rpm"
        ]
      },
      "electronPackagerConfig": {},
      "electronWinstallerConfig": {
        "name": "test"
      },
      "electronInstallerDebian": {},
      "electronInstallerRedhat": {},
      "github_repository": {
        "owner": "",
        "name": ""
      },
      "windowsStoreConfig": {
        "packageName": "",
        "name": "test"
      }
    }
  }

Please provide either a failing minimal testcase (with a link to the code) or detailed steps to
reproduce your problem. Using electron-forge init is a good starting point, if that is not the
source of your problem.
Here is a fresh project where electron-forge start works well but electron-forge make prints the error.

Thanks for your time
@MarshallOfSound MarshallOfSound added the blocked/upstream Issues blocked by upstream bugs label Mar 25, 2017
@malept
Copy link
Member

malept commented Mar 28, 2017

What happens when you use relative paths for @import?

@ajimix
Copy link
Author

ajimix commented Mar 28, 2017

I've just tried and the same thing happens

@JakeDluhy JakeDluhy mentioned this issue Apr 7, 2017
Open
@pamtbaau
Copy link

Any progress on this?

@alreece45 alreece45 mentioned this issue Aug 15, 2017
Open
@MarshallOfSound
Copy link
Member

This issue should be raised upstream at electron-compile. As of electron-forge 6.0.0 electron-compile is not enabled by default 👍

@malept malept mentioned this issue Oct 26, 2018
Closed
3 tasks
@snyk-bot snyk-bot mentioned this issue Sep 13, 2021
Open
dsanders11 pushed a commit that referenced this issue Jan 14, 2023
@felixrieseberg
Merge pull request #182 from electron/electron-logging
b3e25cf 
feat: add an execution toggle to enable advanced electron logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked/upstream Issues blocked by upstream bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable compiling of sass partials. alreece45/electron-compilers
4 participants
@malept @ajimix @pamtbaau @MarshallOfSound