Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include libunity in Linux target #8019

Open
JakobDev opened this issue Jan 30, 2024 · 5 comments
Open

Include libunity in Linux target #8019

JakobDev opened this issue Jan 30, 2024 · 5 comments

Comments

@JakobDev
Copy link

  • Electron-Builder Version:
    24.9.1
  • Node Version:
    21.5.0
  • Electron Version:
    28.9.0

  • Electron Type (current, beta, nightly):
    stable

  • Target:
    Linux

Electron needs libunity for showing a badge and the progress in the window icon. This lib should be included in the Linux target, as it is not pre-installed on most systems.

@mmaietta
Copy link
Collaborator

This sounds like a new requirement in newer electron versions? Can you try adding libunity to the linux depends configuration and see if that resolves your issue? Would like confirmation first before making changes to the code base.

@JakobDev
Copy link
Author

JakobDev commented Feb 1, 2024

This sounds like a new requirement in newer electron versions?

No. This is very old, but it is not documented. It is needed for setProgressBar and setBadgeCount to work on Linux. If Electron can't find this lib, these function just don't work and Electron don't show a Error at all.

Can you try adding libunity to the linux depends configuration and see if that resolves your issue?

You mean the DEB package?

Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Oct 21, 2024
@JakobDev
Copy link
Author

Push

@github-actions github-actions bot removed the Stale label Oct 28, 2024
@mmaietta
Copy link
Collaborator

@JakobDev I found where the default values are coming from, they were located in an upstream dependency app-builder-bin. I've moved the logic into electron-builder, just need to know from you where libunity is supposed to go. Which target does it apply to?

private getDefaultDepends(target: string): string[] {
switch (target) {
case "deb":
return ["libgtk-3-0", "libnotify4", "libnss3", "libxss1", "libxtst6", "xdg-utils", "libatspi2.0-0", "libuuid1", "libsecret-1-0"]
case "rpm":
return [
"gtk3" /* for electron 2+ (electron 1 uses gtk2, but this old version is not supported anymore) */,
"libnotify",
"nss",
"libXScrnSaver",
"(libXtst or libXtst6)",
"xdg-utils",
"at-spi2-core" /* since 5.0.0 */,
"(libuuid or libuuid1)" /* since 4.0.0 */,
]
case "pacman":
return ["c-ares", "ffmpeg", "gtk3", "http-parser", "libevent", "libvpx", "libxslt", "libxss", "minizip", "nss", "re2", "snappy", "libnotify", "libappindicator-gtk3"]
default:
return []
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants