-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Request] Support the Electron Fuse: "EnableEmbeddedAsarIntegrityValidation" #6930
Comments
+1, I think support for electron/fuses would be a great addition. FYI, there was also a closed #6365 issue that request support. |
Closing this one and reopening the other ticket. |
@mmaietta all the other fuses can be used without necessitating changes to Electron Builder itself. This one cannot. I think this should remain open because of that distinction. |
From electron/fuses#7 (comment):
|
Would love to see this on electron-builder, Electron@30 added support for Windows machines as well. |
Is this currently on the roadmap? Given added support for Windows its kinda a big feature. |
The only way to support this is by migrating to |
Released in v26.0.0-alpha.2. Please give it a shot! Verified it locally (on mac build machine) that it launches with that fuse set:
|
Gonna test in a few hours, doing the gods work here, thank you! @mmaietta |
Hmm, while packaging works fine, I'm getting Edit: it seems like adding afterPack script with asarmor breaks, but also not cleaning the dist directory |
Hmmm yeah, from a quick read of asarmor, it's modifying the asar, which then causes the integrity generated/recorded by electron/asar to no longer be valid. Can you try force setting Alternatively, you can play around with @electron/fuses in your afterPack via a convenience method I opened up as part of the integration for those that want to leverage
I'm wondering if you need the |
@mmaietta That doesnt do the trick, maybe because Im on windows, but its not huge deal |
Dam. Well it looks like asarmor is the issue as it manipulates the asar post electron/asar integrity generation since asarmor is injecting random bytes into the asar to prevent extraction. An alternative approach could be using bytenode to obfuscate your code. It doesn't disable extraction like asarmor, but it doesn't require any asar manipulation either. |
Ill take a look, thanks! |
See here for more info: electron/fuses#7 (comment)
The text was updated successfully, but these errors were encountered: