Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove existing uninstaller registry key if exists in NSIS installer #5311

Closed
amiller-gh opened this issue Sep 25, 2020 · 2 comments
Closed
Labels

Comments

@amiller-gh
Copy link

  • Version: All
  • Electron Version: All
  • Electron Type (current, beta, nightly): All
  • Target: Windows NSIS Installer

This is a ticket to track work on #4057 (comment)

When a well-intentioned, but non-technical Windows user wants to un-install and re-install a program, they often try to DELETE ALL THE FILES. However, this leaves vestigial registry keys lingering. Unfortunately, when they manually delete all the files, this often deletes the uninstaller too, leaving us to manually track down orphan registry keys before the NSIS installer can actually work again...

To avoid manual intervention for broken installed, the NSIS installer should remove these registry keys if they exist on each new install.

Users can currently add this functionality through a custom installer init script as referenced here: #4057 (comment)

This functionality should be part of the default NSIS installer script. I'll be tackling this task in mid November, if nobody picks it up before then.

@o2genum
Copy link
Contributor

o2genum commented Oct 12, 2020

I think this is fixed by #4057

However, there has been no electron-builder release with that fix included yet.

@stale
Copy link

stale bot commented Dec 12, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the backlog label Dec 12, 2020
@stale stale bot closed this as completed Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants