Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win zip and snap packages don't follow artifactName #2576

Closed
peterdanis opened this issue Feb 13, 2018 · 1 comment · Fixed by Thorium-Sim/thorium-kiosk#40 · May be fixed by qcif/data-curator#563
Closed

Win zip and snap packages don't follow artifactName #2576

peterdanis opened this issue Feb 13, 2018 · 1 comment · Fixed by Thorium-Sim/thorium-kiosk#40 · May be fixed by qcif/data-curator#563
Labels

Comments

@peterdanis
Copy link
Contributor

  • Version: 20.0.4
  • Target: Win & Mac & Linux, all x64 only

Hi, I am trying to align package names uploaded to Github Releases, but the Win zip package and snap package don't follow the artifactName property. I am building on Appveyor (Win32) and Travis (Linux&Mac). Any hints how to set it up correctly? Thank you in advance.

Win zip target is build with correct name but published with a different one:

  • building        target=zip arch=x64 file=release-builds\Wrapbox_v0.0.5.zip
  ...
  • uploading       file=wrapbox-0.0.5-win.zip provider=GitHub

For Linux targets I set artifactName to ${name}_v${version}.${ext}, but snap package name is different than the rest:

  • building        target=snap arch=x64 file=release-builds/wrapbox_0.0.5_amd64.snap
  ...
  • uploading       file=wrapbox_0.0.5_amd64.snap provider=GitHub
  ...
  • uploading       file=wrapbox_v0.0.5.AppImage provider=GitHub
  • uploading       file=wrapbox_v0.0.5.deb provider=GitHub
  • uploading       file=wrapbox_v0.0.5.rpm provider=GitHub

My build config in package.json:

  "build": {
    "appId": "com.peterdanis.wrapbox",
    "productName": "Wrapbox",
    "copyright": "Copyright © 2018 Peter Danis",
    "asar": false,
    "win": {
      "artifactName": "${productName}_v${version}.${ext}",
      "target": ["nsis", "zip"],
      "icon": "icons/icon.ico",
      "electronUpdaterCompatibility": ">=2.16"
    },
    "mac": {
      "artifactName": "${name}_v${version}.${ext}",
      "category": "public.app-category.productivity",
      "target": ["dmg", "pkg"],
      "icon": "icons/icon.icns"
    },
    "linux": {
      "artifactName": "${name}_v${version}.${ext}",
      "category": "Utility",
      "target": ["AppImage", "deb", "rpm", "snap"],
      "icon": "icons/icon.png"
    },
    "nsis": {
      "oneClick": false,
      "perMachine": false,
      "allowToChangeInstallationDirectory": true,
      "artifactName": "${productName}_v${version}_Installer.${ext}"
    },
    "dmg": {
      "contents": [
        {
          "x": 110,
          "y": 150
        },
        {
          "x": 240,
          "y": 150,
          "type": "link",
          "path": "/Applications"
        }
      ]
    },
    "files": ["app/**"],
    "directories": {
      "output": "./release-builds"
    }
  }
@develar develar added the bug label Mar 6, 2018
@develar
Copy link
Member

develar commented Mar 6, 2018

snap — fixed.
win zip — cannot reproduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment