Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated documentation about docker images #2544

Closed
sin6pi7 opened this issue Feb 1, 2018 · 4 comments
Closed

Deprecated documentation about docker images #2544

sin6pi7 opened this issue Feb 1, 2018 · 4 comments

Comments

@sin6pi7
Copy link

sin6pi7 commented Feb 1, 2018

  • Version: 19.55.3
  • Target: Windows/Linux

Documentation (https://www.electron.build/multi-platform-build) states:

builder:wine — Wine, NodeJS 8 and required system dependencies. Based on builder:8. Use this image if you need to build Windows targets

However, builder:wine image actually contains NodeJS 9:

$ sudo docker run electronuserland/builder:wine node -v                                         
v9.4.0 

Is there a possibility to have an image ready for building Windows targets with specified NodeJS version?

@develar
Copy link
Member

develar commented Feb 1, 2018

Why nodejs 9 is not suitable for you?

@danielecr
Copy link

this my answer to

Why nodejs 9 is not suitable for you?

Because of eslint, for example

error [email protected]: The engine "node" is incompatible with this module. Expected version "^6.14.0 || ^8.10.0 || >=9.10.0".
error Found incompatible module

but my question may be, how can I upgrade/change the used node version? adding:
in Dockerfile like:

FROM electronuserland/builder:wine
RUN node install -g n
RUN n 9.11.1

is ok?

@danielecr
Copy link

RUN node install -g n

---> Running in f333fa3c40e7

module.js:557

throw err;

^

Error: Cannot find module '/project/install'

at Function.Module._resolveFilename (module.js:555:15)

at Function.Module._load (module.js:482:25)

at Function.Module.runMain (module.js:701:10)

at startup (bootstrap_node.js:194:16)

at bootstrap_node.js:618:3

@danielecr
Copy link

so funny ... the correct Dockerfile is:

FROM electronuserland/builder:wine
RUN npm install -g n
RUN n 9.11.1

and it works, I can use node 9.11.1 or whatever using n

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants