Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identity validation option is incorrect #1603

Closed
feens opened this issue May 31, 2017 · 2 comments · May be fixed by qcif/data-curator#563
Closed

Identity validation option is incorrect #1603

feens opened this issue May 31, 2017 · 2 comments · May be fixed by qcif/data-curator#563
Labels

Comments

@feens
Copy link
Contributor

feens commented May 31, 2017

Currently when signing, the option skipIdentityValidation: true, is passed, which I'm assuming is supposed to ensure that electron-osx-sign doesn't do identity validation and uses the identity as passed. However, the correct option for electron-osx-sign is now 'identity-validation': false.

I made mention of this issue in electron/osx-sign#135

@sethlu
Copy link
Member

sethlu commented Jun 1, 2017

Ref:

@develar
Copy link
Member

develar commented Jun 1, 2017

Thanks for spotting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants