Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform-specific build option targets ignored since 15.2.0 #1355

Closed
belltown opened this issue Mar 12, 2017 · 2 comments · May be fixed by qcif/data-curator#563
Closed

Platform-specific build option targets ignored since 15.2.0 #1355

belltown opened this issue Mar 12, 2017 · 2 comments · May be fixed by qcif/data-curator#563
Labels

Comments

@belltown
Copy link

  • 15.3.0:
  • Linux:

I have scripts in my package.json file to build for different platforms. When building for linux, I can specify which target I want in the script. The script will only build for the one target I specify. At least it worked that way as far as the 15.1.1 release. From 15.2.0 onwards, it builds for all linux targets even though I only want one target build.

For example, if I run npm run dist-deb, I used to only get the deb target build. Now I get all the linux targets: AppImage, deb, and rpm.

Is there something I can change in my script to get back to the original behavior of specifying a specific build target option?

Here is my current package.json file:

{
  "name": "violetbug",
  "productName": "VioletBug",
  "version": "0.0.4",
  "private": true,
  "description": "VioletBug -- A Roku Debugger Graphical Interface",
  "main": "main.js",
  "scripts": {
    "start": "electron .",
    "test": "echo If it works, it works",
    "build-win": "electron-packager . violetbug --platform=win32 --arch=x64 --out ../builds/win --overwrite --icon=images/icon.ico --win32metadata.CompanyName=Belltown --win32metadata.ProductName=VioletBug --win32metadata.FileDescription=\"VioletBug Roku Debugger\" --app-copyright=\"Copyright © 2017 Belltown\"",
    "build-linux": "electron-packager . violetbug --platform=linux --arch=x64 --out ../builds/linux --overwrite --icon=images/icon.png --app-copyright=\"Copyright © 2017 Belltown\"",
    "build-mac": "electron-packager . violetbug --platform=darwin --arch=x64 --out ../builds/mac --overwrite --icon=images/icon.icns --app-bundle-id=tk.belltown-roku.violetbug --app-category-type=public.app-category.developer-tools --app-copyright=\"Copyright © 2017 Belltown\"",
    "zip-win": "mkdir -p ../dist && cd ../builds/win && zip -r -q ../../dist/violetbug-win * && cd ../../source",
    "zip-linux": "mkdir -p ../dist && cd ../builds/linux && zip -r -q --symlinks ../../dist/violetbug-linux * && cd ../../source",
    "zip-mac": "mkdir -p ../dist && cd ../builds/mac/violetbug-darwin-x64 && zip -r -q --symlinks ../../../dist/violetbug-mac violetbug.app && cd ../../../source",
    "dist-appimage": "build --linux AppImage",
    "dist-deb": "build --linux deb",
    "dist-rpm": "build --linux rpm",
    "dist-win": "build --win"
  },
  "build": {
    "appId": "tk.belltown-roku.violetbug",
    "directories": {
      "buildResources": "images",
      "output": "../dist/"
    },
    "nsis": {
      "oneClick": true
    },
    "win": {},
    "linux": {
      "target": [
        "AppImage",
        "deb",
        "rpm"
      ],
      "category": "Development",
      "vendor": "Belltown",
      "description": "A cross-platform Roku Debugger graphical interface",
      "icon": "."
    }
  },
  "keywords": [
    "PurpleBug",
    "VioletBug",
    "Roku",
    "debugger",
    "debug",
    "Telnet"
  ],
  "copyright": "Copyright © 2017 Belltown",
  "license": "MIT",
  "author": {
    "name": "Belltown",
    "email": "[email protected]",
    "url": "http://belltown-roku.tk/VioletBug"
  },
  "homepage": "http://belltown-roku.tk/VioletBug",
  "repository": {
    "type": "git",
    "url": "https://github.com/belltown/violetbug"
  },
  "bugs": {
    "url": "https://github.com/belltown/violetbug/issues"
  },
  "//": "Need ajv to satisfy broken peer dependency for electron-builder ...",
  "devDependencies": {
    "ajv": ">=5.0.3-beta.0",
    "electron": "1.6.2",
    "electron-packager": "8.5.2",
    "electron-builder": "15.3.0"
  }
}
@develar
Copy link
Member

develar commented Mar 13, 2017

You have

    "linux": {
      "target": [
        "AppImage",
        "deb",
        "rpm"
      ],

in your config. It means that Linux --linux will build specified targets.

But you explicitly specify target in the command line, so... it is bug.

@develar develar added the bug label Mar 13, 2017
@belltown
Copy link
Author

belltown commented Mar 13, 2017

That fixed it in 15.4.2! Thanks a lot for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants