Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable cache control on check for update #1205

Closed
farfromrefug opened this issue Feb 2, 2017 · 4 comments
Closed

disable cache control on check for update #1205

farfromrefug opened this issue Feb 2, 2017 · 4 comments

Comments

@farfromrefug
Copy link

When using electron http request, you don't set a cache control.
This created an issue for me while getting the latest.json. It was always reading the cache even the file actually changed on my server.
To fix that i actually just added:

        options.headers = options.headers || {};
        options.headers['Cache-Control'] = 'no-cache';

here (though i am not using the very last version)

@develar
Copy link
Member

develar commented Feb 2, 2017

Do you use electron-updater 1.3.1+?

@develar
Copy link
Member

develar commented Feb 2, 2017

We do

headers["Cache-Control"] = "no-cache"
Was fixed this week.

@develar
Copy link
Member

develar commented Feb 2, 2017

Duplicates #1186

@farfromrefug
Copy link
Author

sorry my bad, i was not looking at the same source file, so i thought it was still pending.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants