Trim suffix from wine version #1033
Conversation
|
@cawa-93, thanks for your PR! By analyzing the history of the files in this pull request, we identified @demetris-manikas, @seeekr and @ml1nk to be potential reviewers. |
| @@ -320,6 +320,11 @@ export async function checkWineVersion(checkPromise: Promise<string>) { | |||
| wineVersion = wineVersion.substring(0, spaceIndex) | |||
| } | |||
|
|
|||
| const rcIndex = wineVersion.indexOf("-rc") | |||
There was a problem hiding this comment.
I think, we can just check - to be prepared for another suffixes.
There was a problem hiding this comment.
Then it may be simply makes sense to replace all - on .? In this case, you will see the difference between wine-2.0-rc1 and wine-2.0-rc2. They will be given to the form and 2.0.rc1 2.0.rc2. Semver be able to recognize this type of version?
There was a problem hiding this comment.
may be simply makes sense to replace all "-" on "."?
It is not safe because we don't know format of rc — it can be not valid semver. So, it is better just to trim it.
you will see the difference between wine-2.0-rc1 and wine-2.0-rc2
Not required for now.
|
Thanks for PR! |
* commit 'dcf3dbb48979291fb91301610de9e417e0ab7b79': (43 commits) feat: LSTypeIsPackage for file associations fix: Trim suffix from wine version (electron-userland#1033) fix: Stub Executables missing in Squirrel.Windows 1.5.1 fix: order of platform and arch npm env vars (electron-userland#1029) feat: Set platform npm environment variable feat: Use Electron.Net to send http requests for auto updater docs: typo (electron-userland#1026) refactor: reexport HttpError feat(appx): more customizable manifest fields chore: prefer const feat: 32 bit appx fix: yarn detection feat: update Squirrel.Windows to 1.5.1 fix: update nsis to 3.0.1 docs: Added details about setting AUMID for Windows 8/8.1 notifications. fix: update nsis to 3.0.1 test: attempt to make Win CI green test: use yarn on Appveyor fix: ENOENT for symlinks because directory was not created fix(electron-auto-updater): load default provider only if custom was not set ... # Conflicts: # src/cli/install-app-deps.ts # src/cli/node-gyp-rebuild.ts # src/packager.ts # src/publish/restApiRequest.ts # src/targets/nsis.ts # src/util/httpRequest.ts # src/yarn.ts
This is fix #1031 and #953 issue