Skip to content

Commit

Permalink
fix: log github publisher user and project #425
Browse files Browse the repository at this point in the history
  • Loading branch information
develar committed May 31, 2016
1 parent 0f060c1 commit c2c3ef6
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
7 changes: 4 additions & 3 deletions src/builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { PublishOptions, Publisher, GitHubPublisher } from "./gitHubPublisher"
import { executeFinally } from "./promise"
import { Promise as BluebirdPromise } from "bluebird"
import { InfoRetriever } from "./repositoryInfo"
import { log } from "./util"
import { log, warn } from "./util"
import { Platform, Arch, archFromString } from "./metadata"

//noinspection JSUnusedLocalSymbols
Expand All @@ -17,10 +17,11 @@ export async function createPublisher(packager: Packager, options: BuildOptions,
return null
}

log("Cannot detect repository by .git/config")
throw new Error("Please specify 'repository' in the dev package.json ('" + packager.devPackageFile + "')")
warn("Cannot detect repository by .git/config")
throw new Error(`Please specify 'repository' in the dev package.json ('${packager.devPackageFile}')`)
}
else {
log(`Creating Github Publisher — user: ${info.user}, project: ${info.project}, version: ${packager.metadata.version}`)
return new GitHubPublisher(info.user, info.project, packager.metadata.version, options.githubToken!, options.publish!)
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/gitHubPublisher.ts
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,6 @@ export class GitHubPublisher implements Publisher {
}
}

log("WARN: Cannot delete release " + this._releasePromise.value().id)
warn(`Cannot delete release ${this._releasePromise.value().id}`)
}
}
2 changes: 1 addition & 1 deletion test/src/winPackagerTest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { Arch } from "out"
//noinspection JSUnusedLocalSymbols
const __awaiter = require("out/awaiter")

test.ifNotCiOsx("win", () => assertPack("test-app-one", signed({
test.ifDevOrWinCi("win", () => assertPack("test-app-one", signed({
targets: Platform.WINDOWS.createTarget(),
})
))
Expand Down

0 comments on commit c2c3ef6

Please sign in to comment.