fix: use lowercased safe artifact name if app name is lowercased

electron-userland · Mar 22, 2017 · bfd6635 · bfd6635
1 parent d99a27e
commit bfd6635
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 5 deletions.
diff --git a/packages/electron-builder/src/targets/WebInstaller.ts b/packages/electron-builder/src/targets/WebInstaller.ts
@@ -39,6 +39,8 @@ export default class WebInstallerTarget extends NsisTarget {
   }
 
   protected generateGitHubInstallerName(): string {
-    return `${this.packager.appInfo.name}-WebSetup-${this.packager.appInfo.version}.exe`
+    const appInfo = this.packager.appInfo
+    const classifier = appInfo.name.toLowerCase() === appInfo.name ? "web-setup" : "WebSetup"
+    return `${appInfo.name}-${classifier}-${appInfo.version}.exe`
   }
 }
diff --git a/packages/electron-builder/src/targets/nsis.ts b/packages/electron-builder/src/targets/nsis.ts
@@ -180,7 +180,9 @@ export default class NsisTarget extends Target {
   }
 
   protected generateGitHubInstallerName() {
-    return `${this.packager.appInfo.name}-${this.isPortable ? "" : "Setup-"}${this.packager.appInfo.version}.exe`
+    const appInfo = this.packager.appInfo
+    const classifier = appInfo.name.toLowerCase() === appInfo.name ? "setup-" : "Setup-"
+    return `${appInfo.name}-${this.isPortable ? "" : classifier}${appInfo.version}.exe`
   }
 
   private get isUnicodeEnabled() {

diff --git a/test/out/windows/__snapshots__/installerTest.js.snap b/test/out/windows/__snapshots__/installerTest.js.snap
@@ -5,7 +5,7 @@ Object {
   "win": Array [
     Object {
       "file": "Test Custom Installation Dir Setup 1.1.0.exe",
-      "safeArtifactName": "test-custom-inst-dir-Setup-1.1.0.exe",
+      "safeArtifactName": "test-custom-inst-dir-setup-1.1.0.exe",
     },
   ],
 }
@@ -21,7 +21,7 @@ Object {
 
 exports[`allowToChangeInstallationDirectory 3`] = `
 Object {
-  "githubArtifactName": "test-custom-inst-dir-Setup-1.1.0.exe",
+  "githubArtifactName": "test-custom-inst-dir-setup-1.1.0.exe",
   "path": "Test Custom Installation Dir Setup 1.1.0.exe",
   "version": "1.1.0",
 }

diff --git a/test/out/windows/__snapshots__/oneClickInstallerTest.js.snap b/test/out/windows/__snapshots__/oneClickInstallerTest.js.snap
@@ -29,7 +29,7 @@ Object {
   "win": Array [
     Object {
       "file": "Test Menu Category CustomName 1.1.0.exe",
-      "safeArtifactName": "test-menu-category-Setup-1.1.0.exe",
+      "safeArtifactName": "test-menu-category-setup-1.1.0.exe",
     },
   ],
 }