Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to disable walmart eslint #20

Open
rinaldorossi opened this issue Nov 7, 2016 · 5 comments
Open

How to disable walmart eslint #20

rinaldorossi opened this issue Nov 7, 2016 · 5 comments
Labels

Comments

@rinaldorossi
Copy link

rinaldorossi commented Nov 7, 2016

Hi,
how can I disable the eslint - for example - in eslint-config-defaults/rules/eslint/styles/walmart.js ?

Tks.

@ananavati
Copy link
Contributor

@rinaldorossi thanks for checking out Electrode.

Electrode is built in-house at Walmart and stylint rules are using the rules used at scale and battle-tested and is built on other Open Source linting standards.

@ananavati ananavati added wontfix and removed wontfix labels Nov 10, 2016
@rinaldorossi
Copy link
Author

rinaldorossi commented Nov 10, 2016

@ananavati` Tks for explanation.

I'm trying to change a indent role in eslintrc file in component main directory:

---
extends:
  - "./node_modules/electrode-archetype-react-component/config/eslint/.eslintrc-react"
rules:
indent: [0, 2]

but it seems not work.

even this does not work:

{
"extends": "./node_modules/electrode-archetype-react-component/config/eslint/.eslintrc-react",
  "rules": {
       "indent": 0 
   }
}

@citelao
Copy link

citelao commented Nov 12, 2016

Is this for gulp check?

The issue is that the linting doesn't look to any root .eslintrcs for configuration. See [https://github.com/electrodejs/deprecated-electrode-archetype-react-app/pull/35]

@kirill-konshin
Copy link

kirill-konshin commented Mar 1, 2017

Any updates?

@citelao
Copy link

citelao commented Mar 3, 2017

This repo is deprecated. I would ask here.

Unfortunately, as far as I understand it, archetype-react-component does not support this override, but archetype-react-app does. So if you are building an app, you're in luck. If you are not... not yet. I'd open a issue at the new repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants