-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add arguments to custom actions #48
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a second pass at parsing custom actions but also improves it by automatically skipping comments.
This creates the header required for the desired scoped stack. This implements that as well as listing the available functions and their declared arguments and pastes the defined body.
This allows us to not have to keep track of variables in a separate parsing loop. This also just makes the code for generating custom action calls a lot cleaner.
This reverts commit f10c633.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors custom actions to allow for argument definitions that can then be used later to pass arguments to the defined action.
This makes the following syntax possible:
I'm not crazy about this because it introduces syntax that does not translate directly to shortcuts but having this functionality is very important to users of the language and the prospect of a standard library of custom actions is very interesting to me.