Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS failing to sign Shortcuts on 14.4+ #49

Open
electrikmilk opened this issue Apr 4, 2024 · 5 comments
Open

macOS failing to sign Shortcuts on 14.4+ #49

electrikmilk opened this issue Apr 4, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@electrikmilk
Copy link
Owner

electrikmilk commented Apr 4, 2024

Describe the bug

When signing a Shortcut with the shortcuts binary on macOS through the Cherri compiler, when it attempts to sign the Shortcut produced by Cherri, it produces this output:

Error: Failed to sign Shortcut

shortcuts: ERROR: Unrecognized attribute string flag '?' in attribute string "T@"NSString",?,R,C" for property debugDescription
ERROR: Unrecognized attribute string flag '?' in attribute string "T@"NSString",?,R,C" for property debugDescription
ERROR: Unrecognized attribute string flag '?' in attribute string "T@"NSString",?,R,C" for property debugDescription
ERROR: Unrecognized attribute string flag '?' in attribute string "T@"NSString",?,R,C" for property debugDescription
ERROR: Unrecognized attribute string flag '?' in attribute string "T@"NSString",?,R,C" for property debugDescription
Error: The file “arr.shortcut” couldn’t be saved in the folder “cherri”.

To Reproduce

No code seems to trigger this specifically. Something about the general format of Shortcuts that Cherri currently creates is not compatible with the current version of macOS.

Debug output
Please use the --debug flag and copy the output.

Expected behavior

For the Shortcut to be signed.

Screenshots
If applicable, add screenshots to help explain your problem.

Version Information (please complete the following information):

Darwin Kernel Version 23.4.0

go1.22.1 darwin/arm64

@electrikmilk electrikmilk added the bug Something isn't working label Apr 4, 2024
@electrikmilk
Copy link
Owner Author

electrikmilk commented Apr 4, 2024

This is possibly a macOS bug. debugDescription is not a symbol in the compiler.

The unsigned Shortcut the compiler currently produces I'm not initially seeing anything wrong with.

If you haven't upgraded yet and the compiler still doesn't work, please comment here.

@electrikmilk electrikmilk added the invalid This doesn't seem right label Apr 4, 2024
@electrikmilk
Copy link
Owner Author

This isn't just main either, it's the latest release as well which worked when I last tested it, this is looking to almost certainly be a macOS bug.

Luckily, I tried playground.cherrilang.org, and that worked just fine. So that's good. I will notify the RoutineHub team to hold off on updating the macOS version on their signing server.

@electrikmilk electrikmilk added can't fix This will not be worked on and removed invalid This doesn't seem right labels Apr 5, 2024
@electrikmilk electrikmilk removed the can't fix This will not be worked on label Apr 30, 2024
@electrikmilk electrikmilk self-assigned this Apr 30, 2024
@electrikmilk
Copy link
Owner Author

electrikmilk commented Apr 30, 2024

This has been fixed by 0dc365c.

Thanks to the folks at RoutineHub giving us the OK to use their HubSign service as a sustainable backup signing server for the compiler. The playground has been using this for a while and it works great! They will survey macOS updates to ensure that signing is not broken in the next version before they upgrade.

Much ❤️ to RoutineHub and https://github.com/scaxyz/shortcut-signing-server for making this possible!

@electrikmilk electrikmilk changed the title Shortcuts Failing to sign on macOS 14.4 Shortcuts Failing to sign on macOS 14.4+ Sep 26, 2024
@electrikmilk electrikmilk reopened this Sep 26, 2024
@electrikmilk electrikmilk changed the title Shortcuts Failing to sign on macOS 14.4+ macOS failing to sign Shortcuts on 14.4+ Sep 26, 2024
@electrikmilk
Copy link
Owner Author

electrikmilk commented Sep 26, 2024

Not sure if this is still an issue in Sequoia (macOS 15), I have yet to get around to upgrading my OS.

@electrikmilk
Copy link
Owner Author

I confirmed this is still a bug on Sequoia (macOS 15).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant