Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Andorra<->France exchange config (#7243) #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Andorra<->France exchange config (#7243) #1

wants to merge 1 commit into from

Conversation

crovebi
Copy link
Owner

@crovebi crovebi commented Sep 30, 2024

  • Add connection to map

  • Include Andorra France exchange to FR parser

Closes electricitymaps#7243

  • [ ✅] I have tested my parser changes locally with poetry run test_parser "zone_key"
  • [✅ ] I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes.

@crovebi
Add Andorra<->France exchange config (electricitymaps#7243)
996d357 
* Add connection to map

* Include Andorra France exchange to FR parser
@VIKTORVAV99
Copy link

Hey @crovebi, I assume you meant to create this PR towards https://github.com/electricitymaps/electricitymaps-contrib but it seems you are targeting your own master branch.

Would you mind creating a PR towards our repository instead/as well?

@crovebi
Copy link
Owner Author

crovebi commented Oct 2, 2024

Hello @VIKTORVAV99 I spent quite some time searching for an accurate measurement on the interconnection capacity between France and Andorra, I could not find an official number coming from an Andorran source so there is currently a placeholder number from France's main interconnection line. I would not feel comfortable making the PR until I find the correct value. I hope you understand.

@VIKTORVAV99
Copy link

Hello @VIKTORVAV99 I spent quite some time searching for an accurate measurement on the interconnection capacity between France and Andorra, I could not find an official number coming from an Andorran source so there is currently a placeholder number from France's main interconnection line. I would not feel comfortable making the PR until I find the correct value. I hope you understand.

Hey! 👋

You can add it without an capacity if you wish. Just omit the whole array.

@jackkjenkins jackkjenkins mentioned this pull request Oct 16, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing exchange config between France and Andorra
2 participants
@crovebi @VIKTORVAV99