support changing config after initdb, or editing from user call #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Nov 6, 2024
|
🚀 Deployed on https://67337eec1ec65d3bf6dc1581--pglite.netlify.app |
samwillis
reviewed
Nov 12, 2024
| @@ -419,6 +419,8 @@ export class PGlite | |||
| 'INITDB created a new datadir, but an alternative db/user was requested', | |||
| ) | |||
| } | |||
| // time to mark extensions that need special treatment on startup. | |||
| if (options.postgresqlConf) this.updateConf(options.postgresqlConf) | |||
There was a problem hiding this comment.
If I understand correctly, this runs after initdb. I think I need to add some tests to check is PG correctly reads and process it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nb : does not handle modifying arrays, they are overwritten.