Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3] Improve the logic of update-ips script #1750

Closed
5 tasks done
aarnq opened this issue Sep 1, 2023 · 0 comments
Closed
5 tasks done

[3] Improve the logic of update-ips script #1750

aarnq opened this issue Sep 1, 2023 · 0 comments
Assignees
Labels
kind/improvement Improvement of existing features, e.g. code cleanup or optimizations.

Comments

@aarnq
Copy link
Contributor

aarnq commented Sep 1, 2023

Is your feature request related to a problem? Please describe.
With the work of #1582 done we're improved the functions and general handling of IPs a lot, so now we should focus on improving the logic behind it.

Describe the solution you'd like

  • Better grouping of checks so that as an example all specific for SC may be under the same if statement.
  • Reusable function for looking up keystone+swift endpoints.
  • Reusable functions for extracting domain name and ports from endpoints.
  • Simplify the logic for rclone sync.
  • Moving things to functions to simplify structure and make it more digestible.

Describe alternatives you've considered
Keep current which is harder to maintain.

Definition of done:
The update-ips script is further improved.

@aarnq aarnq added the kind/improvement Improvement of existing features, e.g. code cleanup or optimizations. label Sep 1, 2023
@Xartos Xartos changed the title Improve the logic of update-ips script [3] Improve the logic of update-ips script Oct 6, 2023
@simonklb simonklb self-assigned this Oct 30, 2023
@simonklb simonklb mentioned this issue Nov 2, 2023
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Improvement of existing features, e.g. code cleanup or optimizations.
Projects
None yet
Development

No branches or pull requests

3 participants