Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2] Update the update-ips script to know about Octavia and to allow anchors/overrides #1453

Closed
aarnq opened this issue Mar 13, 2023 · 0 comments · Fixed by #1582
Closed

[2] Update the update-ips script to know about Octavia and to allow anchors/overrides #1453

aarnq opened this issue Mar 13, 2023 · 0 comments · Fixed by #1582
Assignees
Labels
kind/improvement Improvement of existing features, e.g. code cleanup or optimizations.

Comments

@aarnq
Copy link
Contributor

aarnq commented Mar 13, 2023

Is your feature request related to a problem? Please describe.
It is confusing to get warnings about IPs that should exist in the IP lists managed by the update-ips script, since they may be there for a reason but you will not see it unless you manually check either comments in the file or why the got added.
One such point of confusion is the use of Octavia load balancers, since it will want to remove those IPs for every check that is done.

Describe the solution you'd like
I would like it to be aware of when Octavia is in use so it can prompt to add the private subnet instead of adding specific IPs.

Describe alternatives you've considered
Alternatives would be to perhaps preserve comments to show why certain IPs differ or to ignore values with comments when considering the diff, perhaps both for added visibility.
Third alternative would be to just keep override lists, but then it feels like we need to improve our handling of netpol configs in general because it would be too much to maintain in values templates.

(I'm almost more in favour of the second alternative as it would allow us to anchor additions we know we want to keep.)

Definition of done:
The update-ips script is more friendly to use when you need to override IPs.

@aarnq aarnq added the kind/improvement Improvement of existing features, e.g. code cleanup or optimizations. label Mar 13, 2023
@Xartos Xartos changed the title Update the update-ips script to know about Octavia or to allow anchors/overrides Update the update-ips script to know about Octavia and to allow anchors/overrides Mar 31, 2023
@Ajarmar Ajarmar changed the title Update the update-ips script to know about Octavia and to allow anchors/overrides [2] Update the update-ips script to know about Octavia and to allow anchors/overrides May 5, 2023
@robinelastisys robinelastisys self-assigned this May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Improvement of existing features, e.g. code cleanup or optimizations.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants