Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Notify user when no previous run exists #335

Open
justinkambic opened this issue Jun 28, 2021 · 3 comments
Open

[Synthetics] Notify user when no previous run exists #335

justinkambic opened this issue Jun 28, 2021 · 3 comments
Labels
discuss enhancement New feature or request

Comments

@justinkambic
Copy link

justinkambic commented Jun 28, 2021

Is your feature request related to a problem? Please describe.
Today, we provide the user with a screenshot of the last successful check in the Synthetics step view:

image

Describe the solution you'd like
When there is not a previously-successful journey, this area of the UI is devoid of any information:

image

Describe alternatives you've considered
We should provide an empty state for this, notifying them that no previous checks have succeeded and we therefore have no screenshot available for them to view.

Untitled

Additional context
N/A

@justinkambic justinkambic added enhancement New feature or request discuss labels Jun 28, 2021
@paulb-elastic
Copy link

We might need to be careful with the wording, as there could be other reasons for no "last successful" image. With options for images not to be captured at all, or only on bad, there may have been successful runs, it’s just we don’t have images for them. Similarly, depending on the purge time for screenshots, the last successful run may have since had the screenshots purged.

Depending on how expensive it is to query for this information, maybe we can customise the message depending on if there have been successful runs, however we don’t have screenshots for them, compared with there being no successful runs.

If it is too inefficient to find this out, then we should probably use a more generic message, or point to several possible reasons.

@paulb-elastic
Copy link

Also linking to #330 as it's in a related area.

@justinkambic
Copy link
Author

there could be other reasons for no "last successful" image.

We actually query for the last successful step before getting the screenshot for it already, so there is probably no concern with performance. We should definitely make sure all the possible states are covered; last successful step without a snapshot should appear too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants