Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Use KVP data structure for synthetics UI state management #257

Open
justinkambic opened this issue Oct 1, 2020 · 0 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@justinkambic
Copy link

Today, we use an unordered list to contain and query the synthetic journey data in UI state. Given that each of these entities has a unique identifying value check_group, we should update the code to use a KVP-style data structure.

This came up in code review, but we are electing to add it in a follow-up refactor to keep the amount of review churn to a minimum, and because there's no visible differentiation to the end user as to which of these structures is used. This should still be considered a high priority, with the targeted fix being merged as soon as possible.

@justinkambic justinkambic added the enhancement New feature or request label Oct 1, 2020
@justinkambic justinkambic self-assigned this Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant