Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DESIGN] Synthetics MVP #229

Closed
andrewvc opened this issue Jul 7, 2020 · 12 comments
Closed

[DESIGN] Synthetics MVP #229

andrewvc opened this issue Jul 7, 2020 · 12 comments
Assignees
Labels

Comments

@andrewvc
Copy link
Contributor

andrewvc commented Jul 7, 2020

Summary of the problem (If there are multiple problems or use cases, prioritize them)

Data available for use in UI

  • Per run
    • Overall status (up/down) (required)
    • DOM source for the final step
    • Filmstrip
    • Waterfall (v2)
  • Individual steps
    • Name of the step (user defined) (required)
    • Source code that powers the step (required)
    • Status (Success, Fail, Skipped) (required)
    • Screenshot (full page) (required)
    • Did this step contain the largest contentful paint? (boolean)
    • Length of time the step took (required)

User stories
See user stories here: https://docs.google.com/document/d/19STPufkUdsMSpuCfn0XZoHdpfoG5Ng44-2a-WHBwyBI/edit#

List known (technical) restrictions and requirements

If in doubt, don’t hesitate to reach out to the #observability-design Slack channel.

@elasticmachine
Copy link

Pinging @elastic/observability-design (design)

@andrewvc andrewvc changed the title Synthetics MVP [DESIGN] Synthetics MVP Jul 8, 2020
@drewpost
Copy link

cc: @andrewvc @katrin-freihofner

A few comments/questions:

  • If we're capturing timing information, is it possible to capture two values? One for backend (ie TTFB or responseEnd) and one for "page load" ie onLoadStart- Is this massively more work?
  • I think we should consider pass/fail as language vs up/down. Something that communicated functionality vs availability?
  • What increments will the filmstrip be in? 0.1 seconds is probably the best granularity. Will the user have control over the granularity? Is the filmstrip downloadable/exportable?

@drewpost
Copy link

Another thought - we should have something to indicate when a step is not a full page load so the user isn't expecting to see the full complement of data that comes from a page load

@andrewvc andrewvc mentioned this issue Aug 19, 2020
11 tasks
@andrewvc
Copy link
Contributor Author

@katrin-freihofner this screenshot from a POC might be helpful

image

@justinkambic
Copy link

@katrin-freihofner I had a few follow-up questions:

  1. When a snapshot is selected, do we want to display the full image as a modal, popover, or some other element?
  2. How should we make the empty state for snapshot images look?
    image

@katrin-freihofner
Copy link
Contributor

@justinkambic

  1. When a snapshot is selected, do we want to display the full image as a modal, popover, or some other element?

My initial thought was to show the preview always in 16:9 and the full screenshot on hover.
screenshot-preview

But I think we should also show the full screenshot in full size as an overlay when the preview image is clicked. Especially on smaller screens or touch devices, this could be useful.

  1. How should we make the empty state for snapshot images look?
    image

This is what I had in mind
Screenshot 2020-09-22 at 10 45 42

@shahzad31
Copy link

I love this :)
image

@justinkambic
Copy link

Ok thanks for clearing those up Katrin!

@justinkambic
Copy link

justinkambic commented Sep 22, 2020

I love this :)

@shahzad31 one of the perks of the job is getting to make placeholders like this

@katrin-freihofner
Copy link
Contributor

Design update:
Figma file
Video walk-through

@katrin-freihofner
Copy link
Contributor

I started creating engineering issues for this one.

@katrin-freihofner
Copy link
Contributor

katrin-freihofner commented Oct 19, 2020

Missing pieces:

  • layout and details for expanded row
  • empty/error states

Screenshot 2020-10-19 at 16 02 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants